search

TomographicImaging / CIL

A versatile python framework for tomographic imaging
https://tomographicimaging.github.io/CIL/
Apache License 2.0
98 stars 45 forks source link

Ring remover copyrite #1375

Open gfardell opened 2 years ago

gfardell commented 2 years ago

The ring remover processor uses code taken from the paper. It is adapted from matlab but to me seems like a copy/paste and not a reimplementation of the algorithm. We need to check for a license (from the authors/journal?) and if one exists credit it, otherwise remove the code.

CIL: https://github.com/TomographicImaging/CIL/blob/2f83655d910a94345d52b4930551cfb3958d1550/Wrappers/Python/cil/processors/RingRemover.py#L152-L174

Paper: image

https://opg.optica.org/oe/fulltext.cfm?uri=oe-17-10-8567&id=179485

MartinTurner13 commented 2 years ago

Was submitted back in 2009 - did not have as much formal statements on open access.

At the bottom does have: "A java application of the filter can be freely downloaded from" but link not working (at moment) for me. Again no specific license seen! Email the authors and ask, I see Pavel is still at PSI pavel.trtik@psi.ch

epapoutsellis commented 2 years ago

I think exactly the same code is used in tomopy. I do not know if there is a licence, but we should cite it.