search

TorchEnsemble-Community / Ensemble-Pytorch

A unified ensemble framework for PyTorch to improve the performance and robustness of your deep learning model.
https://ensemble-pytorch.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.05k stars 95 forks source link

Fix `ReduceLROnPlateau` scheduler for all regressors and classifiers #128

Closed SarthakJariwala closed 1 year ago

SarthakJariwala commented 1 year ago

Fixes #109

SarthakJariwala commented 1 year ago

@xuyxu I've implemented fixes for all classifiers and regressors except SnapShot one (since its automatically set there)

Should LR scheduling be independent or the same for all ensembles (as currently implemented in the PR)?

xuyxu commented 1 year ago

Thanks for your great work @SarthakJariwala!

Kind of busy these days, and I will take a look in a few days.

xuyxu commented 1 year ago

@all-contributors please add @SarthakJariwala for code, test

allcontributors[bot] commented 1 year ago

@xuyxu

I've put up a pull request to add @SarthakJariwala! :tada:

xuyxu commented 1 year ago

Merged, thanks for your nice code!