Tormak9970 / TabMaster

Plugin for editing library tabs on the Steamdeck
GNU General Public License v3.0
38 stars 8 forks source link

[FLTR]: "Merge - Blacklist", "Merge - Whitelist" #61

Closed jasonmbrown closed 1 year ago

jasonmbrown commented 1 year ago

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

Tormak9970 commented 1 year ago

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

It would make more sense to have a not option for any filter imo. We also added a manual refresh button in v1.3.0

jasonmbrown commented 1 year ago

I agree that a not would make more sense but I feel that it might make things a bit more complicated on the users. A not function would work for me though.

On Fri, Jul 7, 2023 at 5:55 PM Jason Brown @.***> wrote:

On Fri, Jul 7, 2023 at 5:55 PM Travis Lane @.***> wrote:

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

It would make more sense to have a not option for any filter imo. We also added a manual refresh button in v1.3.0

— Reply to this email directly, view it on GitHub https://github.com/Tormak9970/TabMaster/issues/61#issuecomment-1626398942, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYXUHZQFKE3LQS6KDHWYA3XPCVW7ANCNFSM6AAAAAA2CN57TA . You are receiving this because you authored the thread.Message ID: @.***>

Tormak9970 commented 1 year ago

I agree that a not would make more sense but I feel that it might make things a bit more complicated on the users. A not function would work for me though.

On Fri, Jul 7, 2023 at 5:55 PM Jason Brown @.***> wrote:

On Fri, Jul 7, 2023 at 5:55 PM Travis Lane @.***> wrote:

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

It would make more sense to have a not option for any filter imo. We also added a manual refresh button in v1.3.0

— Reply to this email directly, view it on GitHub https://github.com/Tormak9970/TabMaster/issues/61#issuecomment-1626398942, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYXUHZQFKE3LQS6KDHWYA3XPCVW7ANCNFSM6AAAAAA2CN57TA . You are receiving this because you authored the thread.Message ID: @.***>

We can find a way to make it intuitive. having "blacklist merge groups" sounds like a lot of work that could easily be avoided

jasonmbrown commented 1 year ago

I understand. No point in doing extra work for very little gain. Also on the topic of interface, I’m not sure how complicated it would be but adding something like a preview button or a text based list to the side of the interface that shows what games would show in the tab as it’s being worked on. I don’t know much about decky loaders api though so I’m unsure if this would be simple or not.

On Fri, Jul 7, 2023 at 6:01 PM Travis Lane @.***> wrote:

I agree that a not would make more sense but I feel that it might make things a bit more complicated on the users. A not function would work for me though.

On Fri, Jul 7, 2023 at 5:55 PM Jason Brown @.***> wrote:

On Fri, Jul 7, 2023 at 5:55 PM Travis Lane @.***> wrote:

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

It would make more sense to have a not option for any filter imo. We also added a manual refresh button in v1.3.0

— Reply to this email directly, view it on GitHub

61 (comment)

https://github.com/Tormak9970/TabMaster/issues/61#issuecomment-1626398942 , or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACYXUHZQFKE3LQS6KDHWYA3XPCVW7ANCNFSM6AAAAAA2CN57TA . You are receiving this because you authored the thread.Message ID: @.***>

We can find a way to make it intuitive. having "blacklist merge groups" sounds like a lot of work that could easily be avoided

— Reply to this email directly, view it on GitHub https://github.com/Tormak9970/TabMaster/issues/61#issuecomment-1626400592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYXUH6R4WXURLRAB7DPNFLXPCWMZANCNFSM6AAAAAA2CN57TA . You are receiving this because you authored the thread.Message ID: @.***>

jessebofill commented 1 year ago

Yeah inverting filters is something I wanted to do for next release

jessebofill commented 1 year ago

I would appreciate some method of adding someway to "blacklist" Collections from a selection. (Having a setting to Manually Refresh vs Automatically Refresh would also be nice)

EG: Tab Name = Non Steam - Emulation Group Combination Logic = And Filter 1: Platform Selected Platform = Non Steam Filter 2: Merge - mode: Blacklist -Filter 1: Collection -Collection = Gameboy Advance -Filter 2: Collection -Collection = Gamecube

Basically I want to create a tab that contains My manually added PC Games, But doesn't contain all my emulation stuff. I have over 8000 steam Library games so the Simple Blacklist and Whitelist take literally forever to deal with. Alt

To properly achieve this for now you would use merge filter in “or” mode and it would contain a collection filter for every collection except the ones you want to exclude. The merge filter would be combined as you have it at the top level in “and” mode

jessebofill commented 1 year ago

To clarify a blacklist/ whitelist merge filter doesn’t make sense as that’s not the way they are intended to work. They meant to combine filters the same way you are combining at the top level and shouldn’t have any special mode of operation.

As stated a not operator per filter will essentially “blacklist” that filter and would be applicable to any filter type.

jasonmbrown commented 1 year ago

Unfortunately the games I added manually don't have a "collection" so I cant use the "or" filter. But a not operator sounds great, I look forwards to the next update =). Thank you very much for taking your time to respond!

jessebofill commented 1 year ago

Unfortunately the games I added manually don't have a "collection" so I cant use the "or" filter. But a not operator sounds great, I look forwards to the next update =). Thank you very much for taking your time to respond!

Ah I see. No problem. We’ll update this thread once it get’s implemented.

Tormak9970 commented 1 year ago

this is now resolved with the completion of #63 (invert option)