ToroCraft / ToroHealth

GNU General Public License v3.0
64 stars 50 forks source link

Hide health bars for armor stands and invisible entities that aren't glowing #116

Closed Njol closed 3 years ago

Njol commented 3 years ago

Armor stands should not have health bars, see PR #61.

Invisible entities also should not have health bars, see issue #86. The health bar of invisible entities is shown if they are glowing though, as the glowing effect makes them (partially) visible again.

Since there is no branch for 1.16.5 this PR targets 1.16.3.

frodare commented 3 years ago

Please rebase this into a single commit off of commit 9d7af0f0e32e6b109f22e61dc44225cd7bad531d.

Njol commented 3 years ago

This would be a single commit if there was a branch for 1.16.5 that this PR could target. It is based on the commit just before (0e3e1a1). By creating a branch at say commit 9d7af0f and retargetting this PR only one commit will show here.

frodare commented 3 years ago

I have created a 1.16.5 branch you can target.

Njol commented 3 years ago

Great, I edited all my PRs to target the new branch.

frodare commented 3 years ago

I finally got time to build and deploy your fixes. Thanks for your help! I am releasing the changes from this PR and the others as torohealth-1.16.5-fabric-6.jar. I am thinking some of these changes might help the optifine problems in the 1.17.1 build too.