Meorawr
commented
3 months ago I suspect no one has an import string old enough that just has a VA field and no V2, so testing a change to the import logic would be a pain anyway. Honestly - maybe we just kill the VA support completely and say 6+ year old profile imports aren't supported.
This removes support for sending the old 0-6 range VA field as part of trait comms. The VA field was deprecated and replaced by V2 all the way back in 2018, so there should be nothing on the network that requires it.
For receipt, we still process the VA field if there's no V2 field in viewed profile data. The cost of keeping this around is minimal for now, and we can kill it off some other time if that ever changes.
Additionally some improvements have been made to our serialization of custom trait colors for transmission to try and reduce wire consumption.
Unfortunately when custom colors were added they were transmitted in RGB table form rather than hex colors, so are subject to a bit of blow-up if color components are a bit too exact. We now try and round them to 2 significant digits prior to transmission, so there's a bit of lost information but it should be mostly accurate.