search

TouwaStar / Galaxy_Plugin_Minecraft

MIT License
16 stars 5 forks source link

Minor change to authentication phase #13

Closed urwrstkn8mare closed 3 years ago

urwrstkn8mare commented 3 years ago

I've addressed the concerns of @FriendsOfGalaxy in https://github.com/FriendsOfGalaxy/galaxy-integration-minecraft/pull/8#discussion_r491052701. I've unfortunately only been able to do the easy option as I've had less time in the holidays then I initially imagined. I've tested the migration but I'm not sure if I've done it properly so some additional testing by @TouwaStar or @FriendsOfGalaxy would be appreciated.

@TouwaStar I think it would be better to wait for @FriendsOfGalaxy to confirm this before accepting the PR, otherwise, I might have to open another PR.

FriendsOfGalaxy commented 3 years ago

LGTM tested 👍

FriendsOfGalaxy commented 3 years ago

@TouwaStar @urwrstkn8mare

urwrstkn8mare commented 3 years ago

@TouwaStar, no pressure but any idea when you'll be able to review this?

TouwaStar commented 3 years ago

@urwrstkn8mare sorry, wasn't looking at github lately, Looks ok, merging