ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
191 stars 49 forks source link

Add option to skip DFP check #32

Open SammysHP opened 7 months ago

SammysHP commented 7 months ago

The tinyAVR 0/1 series are supported by avr-libc (development version, no release yet), thus the "proprietary" Atmel DFP isn't necessary.

In the past one was able to fake its existence by setting an environment variable. The new build script sets that variable by itself and makes it impossible to override the location.

ToyKeeper commented 6 months ago

Does commit 0725045fc2d6f974f50d59755f9bbecd0c33ee23 fix this issue?

If I understand correctly, it should be sufficient to skip the "make dfp" step during setup, since the system libraries should provide the necessary headers.

SammysHP commented 6 months ago

Yes, it works. Actually that's more than I asked. My idea was something like an environment variable like DISABLE_DFP_CHECK, that I can add to my Docker image.

SiteRelEnby commented 6 months ago

Could always merge this one ;)

https://github.com/ToyKeeper/anduril/pull/12

gretel commented 6 months ago

in the meantime https://github.com/ToyKeeper/anduril/commit/0725045fc2d6f974f50d59755f9bbecd0c33ee23