Traewelldroid / traewelldroid

Android app for @Traewelling public transport check-in service
https://traewelldroid.de
GNU Affero General Public License v3.0
72 stars 11 forks source link

Wrong line icon shown for RB 16 / RE 16 lines of DB Regio Bayern #366

Open sebiIO opened 4 months ago

sebiIO commented 4 months ago

Describe the bug Traewelldroid shows the same line icons for the RB 16 and RE 16 lines of DB Regio Bayern since they share the same line id. The RB 16 line (München - Treuchtlinen - Nürnberg) shows the correct line icon. The RE 16 line (Augsburg - Nürnberg) shows the wrong line icon.

HAFAS recently changed some line ids which resulted both lines getting the same id (3-800765-16).

I think the app could try to match the line names to the display names of the line-color entries if there is more than one entry for a particular line id.

To Reproduce Steps to reproduce the behavior:

  1. Search for "Treuchtlingen" station (or any other station where both lines run).
  2. Search for departures to "München Hbf" and "Augsburg Hbf".
  3. Notice that both departures have the RB 16 line icon (which the "Augsburg Hbf" one should not).

Expected behavior The RE 16 line should show it's correct line icon.

Screenshots image

Smartphone (please complete the following information):

jheubuch commented 4 months ago

Technically, it's not a bug since there is the correct line icon for the correct line id displayed. I will think about how I (hopefully) can fix that but I can't promise anything.