TravelPouch / travelpouch

2 stars 3 forks source link

Improve UI and logical review on EditTravelSettings #223

Closed appellet closed 1 day ago

appellet commented 3 days ago

Improve the UI and the logic of Edit Travel Screen and Participant settings

The Add User button has been moved to the participant list screen.

RemIsMyWaifuu commented 1 day ago

I see you've made the dismiss change I asked for. It would have been simpler to have the plus button always being displayed and changing to a minus. Your solution is over engineered but it works.

Last thing, I saw you changed it to fillMaxWidth(0.8f) as I suggested, however why did you want to shrink it horizontally in the first place? In other screens we had it fillMaxWidth() which by default is fillMaxWidth(1.0f).

appellet commented 1 day ago

I wanted to normalize the width to ensure a more consistent and balanced layout across different text field sizes. By limiting the width, it prevents the element from appearing too stretched on larger screens, helping maintain a more uniform design.

But, I didn’t initially consider how it might look on other screens, so I appreciate your suggestion. I’ve updated it to match your recommendation and make it more consistent across different screen sizes.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud