search

TremoloSecurity / MyVirtualDirectory

Open Source LDAP Virtual Directory
Apache License 2.0
45 stars 18 forks source link

JdbcInsert neglects chain.nextXYZ() #83

Open wjcarpenter opened 4 years ago

wjcarpenter commented 4 years ago

MyVD 1.0.6.

Several of the stub methods in JdbcInsert don't call the next interceptor in the chain, effectively making JdbcInsert a dead end for those methods. For example, postSearchEntry and postSearchComplete. Is that a bug, or is it intentional for some reason that I don't grok?

FWIW, I'm trying to work around issue #82, and I finally discovered why my insert isn't getting invoked after JdbcInsert.

mlbiam commented 4 years ago

JDBCInsert is meant to be the last in the chain. What do you want to run after the jdbc insert?

wjcarpenter commented 4 years ago

I wanted to have an insert modify binary attributes, and I had wrongly assumed they were not available until after the JdbcInsert had done its thing. But I see now that all of the accumulated LDAPattributes are present in postSearchEntry() when I put my insert before JdbcInsert. Other than that, it was mostly curiosity that made me ask after I noticed it.

Feel free to close the issue if it's ... not an issue. :-)