search

Tresjs / cientos

Collection of useful helpers and fully functional, ready-made abstractions for TresJS
https://cientos.tresjs.org/
MIT License
290 stars 40 forks source link

refactor(shapes): remove v-bind=$attrs on root element #526

Open andretchen0 opened 2 days ago

andretchen0 commented 2 days ago

Problem

Many root elements in Cientos' shape components include v-bind="$attrs". This is unnecessary.

From Vue docs: When a component renders a single root element, fallthrough attributes will be automatically added to the root element's attributes.

https://vuejs.org/guide/components/attrs.html#attribute-inheritance

Solution

Remove v-bind="$attrs" from root elements.

netlify[bot] commented 2 days ago

Deploy Preview for cientos-tresjs ready!

Name Link
Latest commit 6ad5b919316b902339dc544cb91c0ce13c9c92cb
Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/673eb5e637a460000884d49f
Deploy Preview https://deploy-preview-526--cientos-tresjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.