TriForceX / MiyooCFW

Custom firmware source code and resources for BittBoy, PocketGo, PowKiddy V90-Q90-Q20 and third party handheld consoles
GNU General Public License v2.0
1.11k stars 112 forks source link

add extra artifacts with git HEAD tag on action build #483

Closed Apaczer closed 1 year ago

Apaczer commented 1 year ago

MiyooCFW-BETA (with two final images) MiyooCFW submodules (with all generated submodules binaries/modules)

appending name with last commit tag.

tiopex commented 1 year ago

maybe we should build submodules using SDK built from bulidroot? Bulid image+sdk -> fetch and install SDK -> build submodules

Apaczer commented 1 year ago

We could add to buildroot the toolchain.yml: update CONTAINER->sumbodules use that one. Also I will try to shorten this one to only use *.yml specified in submodules repo and work from:

    uses: MiyooCFW/repo_path
    with:
      submodule: name_of_submodule

No need to specify new instructions here if we have ones already in appriopate repo.

nfriedly commented 1 year ago

@tiopex

maybe we should build submodules using SDK built from bulidroot? Bulid image+sdk -> fetch and install SDK -> build submodules

I initially tried to avoid building the SDK on every CI build mainly because it takes so long. (Also, as I understand it, it's common with buildroot to use a prebuilt SDK and just build the image most of the time.) I had the toolchain repo generate a docker image with the SDK and other tools pre-installed whenever the SDK changed, and then the other repos use that image.

Not that we have to do it my way, just wanted to explain the reasoning.


@Apaczer

Also I will try to shorten this one to only use *.yml specified in submodules repo...

Definitely agree with this. I started that process, but never finished it. A couple of FYI things:

Apaczer commented 1 year ago

ok, marking this as complete.

I added delete-artifact@v2 for purging reocurring artifacts in action builds - as a safety it runs with continue-on-error.

For submodules package (after removing unnecessary stuff) I had to move everything to submodules/ dir to fetch upload from there, otherwise it grabs hidden git metadata.

Currently every build is running from appropriate jobs.submodule. This should suffice for now.