Closed Apaczer closed 1 year ago
maybe we should build submodules using SDK built from bulidroot? Bulid image+sdk -> fetch and install SDK -> build submodules
We could add to buildroot the toolchain.yml: update CONTAINER->sumbodules use that one. Also I will try to shorten this one to only use *.yml specified in submodules repo and work from:
uses: MiyooCFW/repo_path
with:
submodule: name_of_submodule
No need to specify new instructions here if we have ones already in appriopate repo.
@tiopex
maybe we should build submodules using SDK built from bulidroot? Bulid image+sdk -> fetch and install SDK -> build submodules
I initially tried to avoid building the SDK on every CI build mainly because it takes so long. (Also, as I understand it, it's common with buildroot to use a prebuilt SDK and just build the image most of the time.) I had the toolchain repo generate a docker image with the SDK and other tools pre-installed whenever the SDK changed, and then the other repos use that image.
Not that we have to do it my way, just wanted to explain the reasoning.
@Apaczer
Also I will try to shorten this one to only use *.yml specified in submodules repo...
Definitely agree with this. I started that process, but never finished it. A couple of FYI things:
actions/checkout@v2
and actions/upload-artifact@v2
that it complains about on the build summary with the @v3
equivalents will reduce it by 2, in addition to silencing those warnings.with: submodule: ...
bit is just something I made up. The workflow is called at the top-level in it's own repo, but we want it to operate in a subdirectory when running it from the main repo. So I pass in the name of that subdirectory in the submodule
parameter. It makes the original workflow a bit more complex, but it was the best I could come up with.ok, marking this as complete.
I added delete-artifact@v2 for purging reocurring artifacts in action builds - as a safety it runs with continue-on-error
.
For submodules package (after removing unnecessary stuff) I had to move everything to submodules/
dir to fetch upload from there, otherwise it grabs hidden git metadata.
Currently every build is running from appropriate jobs.submodule. This should suffice for now.
MiyooCFW-BETA (with two final images) MiyooCFW submodules (with all generated submodules binaries/modules)
appending name with last commit tag.