Open NikunjKhangwal opened 7 months ago
Hmm. Replacing the checkboxes with switches is easy and I do want to implement it (I forgot when doing the borderless buttons last time, oops). As for the white theme, I usually leave the default device theme, but I can try to add a switch to choose like on URLCheck. Hopefully one day...
As for consistent icons, I tried to use only default ones (This makes the app considerably smaller in size) but it's true that it's a mess (it's a shame that manufacturers can't provide a default set of common icons...) I can try to maybe replace the worst ones. On my device it's not so bad though.
Maybe the notification is the less "obvious"?
I meant to say the app stays black even in light mode. Should've explained it better, my bad. You're correct it should follow default device theme. For icons, you can use material icons provided by Google. They are free to use, looks nice and has every icon covered. https://fonts.google.com/icons
Now we're talking about it i noticed URLCheck icons size is inconsistent too. Their position is also misaligned
I just checked, and yes the theme is the device default, but since the app supports very old devices it uses a "default" that is not optimized for newer ones (because for some reason android doesn't have a real "default" theme). I now know a bit more about it so it should be possible to replicate the same code as URLCheck and allow more types of "default".
And yes, I do know about those icons (in fact you can easily generate them directly from android studio itself). What I was complaining is that you need to add them to your app, because the official set of icons available (in the device, that all apps can use without wasting extra storage) is poor and heterogeneous. At least new devices can benefit from vector icons...
Now we're talking about it i noticed URLCheck icons size is inconsistent too. Their position is also misaligned
Right! This is because the buttons themselves are centered, the icon is part of the button.
On my device it's more noticeable nop, it's the same, the line red probably confused me.
I think I can align them. Can you please create a new issue in that repo? Thanks!
And yes, I do know about those icons (in fact you can easily generate them directly from android studio itself). What I was complaining is that you need to add them to your app, because the official set of icons available (in the device, that all apps can use without wasting extra storage) is poor and heterogeneous. At least new devices can benefit from vector icons...
Got it. Honestly just update them. The app is already around 300KB. Raching around 1MB isn't going to change much.
I was bored so i decided to make a concert art. They look pretty nice.
Do you have plans to upgrade the look of app a bit? I'm not talking about a complete material you redesign but things from your own app URLCheck like a white pop-up window, slider buttons instead of check marks and consistent icons etc.