TriliumNext / Notes

Build your personal knowledge base with TriliumNext Notes
https://triliumnext.github.io/Docs/
GNU Affero General Public License v3.0
1.08k stars 60 forks source link

Feature/bare2share: implement redirect anonymous bare url to /share page #667

Open maphew opened 4 days ago

maphew commented 4 days ago

addresses #658 Adds Options >> Other >> Share Settings:


Some of the intemediate commits use custom urls for both Share and Login. I rolled back because was getting too complicated. For example, what if user defined urls that are already used by existing routes? We'd need to add path validation and probably other stuff too.

My motivation was to obscure the login link in order to provide a little protection from simple bot attacks. It's likely better to take a considered security look (from folks who know this space!)

perfectra1n commented 4 days ago

I understand about the motivation - but security through obscurity doesn't count for much unfortunately. Definitely a cool idea though, I dig the effort 💪

maphew commented 4 days ago

current code is not working. :-/ converted to draft. Somehow what I committed differs from what I had running and working. I'm tracking that down now.

maphew commented 4 days ago

Cleaned up and believed ready for review.