search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.13k stars 341 forks source link

Gradle 6.3 incompatibility - Deprecation logging method moved #797

Closed mikehardy closed 4 years ago

mikehardy commented 4 years ago

Describe the bug

An internal deprecation logging method from gradle is referenced here:

https://github.com/Triple-T/gradle-play-publisher/blob/88485d158b940bed40fa22f8dd9a6ae92b118d53/play/plugin/src/main/kotlin/com/github/triplet/gradle/play/internal/Validation.kt#L30

The mechanism for emitting deprecation messages changed between gradle 6.2.2 and 6.3 https://github.com/gradle/gradle/pull/12265

How To Reproduce

Use a PKCS12 authentication style (I know, I should change, but it's deprecated not removed yet...)

Versions

Tasks executed

Fails to load the build.gradle file, just doing ./gradlew wrapper to update to gradle 6.3 triggered this, assuming you have a pkcs12 GCP config file vs JSON

Expected behavior

Should work, with a deprecation message

Additional context (if a crash, provide stack trace)

2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: java.lang.NoSuchMethodError: org.gradle.internal.deprecation.DeprecationMessageBuilder.undocumented()Lorg/gradle/internal/deprecation/DeprecationMessageBuilder$WithDocumentation;
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at com.github.triplet.gradle.play.internal.ValidationKt.validateCreds(Validation.kt:30)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at com.github.triplet.gradle.play.PlayPublisherPlugin$applyInternal$1.execute(PlayPublisherPlugin.kt:141)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at com.github.triplet.gradle.play.PlayPublisherPlugin$applyInternal$1.execute(PlayPublisherPlugin.kt:52)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at org.gradle.internal.ImmutableActionSet$SingletonSet.execute(ImmutableActionSet.java:225)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at org.gradle.api.internal.DefaultDomainObjectCollection.doAdd(DefaultDomainObjectCollection.java:264)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at org.gradle.api.internal.DefaultDomainObjectCollection.add(DefaultDomainObjectCollection.java:253)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at com.android.build.gradle.AppExtension.addVariant(AppExtension.java:84)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   at com.android.build.gradle.internal.ApiObjectFactory.create(ApiObjectFactory.java:127)
2020-03-31T13:17:20.263-0500 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]   ... 143 more

I rely on this plugin and like it a lot, thanks for producing it. It's my hope this bug report is helpful and I'll have a potential patch in a moment