search

Triple-T / gradle-play-publisher

GPP is Android's unofficial release automation Gradle Plugin. It can do anything from building, uploading, and then promoting your App Bundle or APK to publishing app listings and other metadata.
MIT License
4.13k stars 341 forks source link

Task bootstrap fails because of PROMO_GRAPHIC #852

Closed NitroG42 closed 4 years ago

NitroG42 commented 4 years ago

Describe the bug

When running the bootstrap task, it seems the Play API has changed because I get the following error:

      > A failure occurred while executing com.github.triplet.gradle.play.tasks.Bootstrap$ImageFetcher
         > 400 Bad Request
           GET https://www.googleapis.com/androidpublisher/v3/applications/myapp/edits/09106388581678554781/listings/fr-FR/promoGraphic
           {
             "code" : 400,
             "errors" : [ {
               "domain" : "global",
               "message" : "PROMO_GRAPHIC images are no longer supported.",
               "reason" : "badRequest"
             } ],
             "message" : "PROMO_GRAPHIC images are no longer supported.",
             "status" : "INVALID_ARGUMENT"
           }

How To Reproduce

Just run bootstrap task

Versions

Tasks executed

./gradlew app:bootstrapRelease

Expected behavior

No error in the task !

NitroG42 commented 4 years ago

The task fails but the available resources are downloaded (which is a good news)

sduduzog commented 4 years ago

The thing is, after that, I couldn't publish at all

SUPERCILEX commented 4 years ago

Dang, they must have changed the API. If you can't publish right now, you'll need to delete the promo-graphic folder.

sduduzog commented 4 years ago

I hope it's not the fact that I've opted in to their new beta dashboard. I doubt the new flashy console UI didn't come with a whole API upgrade

Dohmanlechx commented 4 years ago

We are getting failed CircleCI builds due to this issue as well.

I removed all the promo-graphic folders and then the tests passed.

jpage4500 commented 4 years ago

@SUPERCILEX @Dohmanlechx - I'm also getting this issue running ./gradlew bootstrap. I'm not trying to upload anything and don't have any promo-graphic folder locally. I just wanted to pull down the latest google play resources.

Also, I looked at the store presence and I don't have a promo graphic set here either.. thoughts?

image

jpage4500 commented 4 years ago

sorry, forgot to mention I'm running the latest version 2.8.0.. guessing the fix that was checked-in just isn't in that version yet

SUPERCILEX commented 4 years ago

Correct, the fix is in 3.0. If people really want it, I could create a patch release.

jpage4500 commented 4 years ago

Sorry, when I first found this I noticed the issue was closed and assumed it was fixed.. my bad! I don't think it's going to prevent updating the app normally so I can wait until 3.0!

thanks

ufuji1984 commented 4 years ago

@SUPERCILEX

If people really want it, I could create a patch release.

At least I (and my colleagues) want it !! 🙇‍♂️ 🙇‍♂️ 🙇‍♂️

SUPERCILEX commented 4 years ago

Ok, will hopefully have time over the weekend.

ufuji1984 commented 4 years ago

Very glad if you could !!! 😭 😭 😭

SUPERCILEX commented 4 years ago

Alrighty, I've just released 2.8.1 which should fix the issue.

ufuji1984 commented 4 years ago

Thank you so much !!!