TritonDataCenter / node-manta

Node.js SDK for Manta
75 stars 54 forks source link

"make test" does not run all tests #235

Closed jclulow closed 9 years ago

jclulow commented 9 years ago

It seems that the Makefile target for running tests does not function as intended. It is specified thus:

.PHONY: test
test: deps
    $(NODEUNIT) test/*.test.js

In practice, this expands out to:

./node_modules/.bin/nodeunit test/client.test.js test/utils.test.js

For whatever reason, nodeunit appears to be running only the first file on the command line. This means utils.test.js doesn't run, and new tests added in separate files are unlikely to run either.

jclulow commented 9 years ago

It seems pretty likely that everything in test/helper.js ought to go away -- especially the use of domains and the excessive use of once. Something in the mess that's in there is preventing the test runner from running all of the tests -- and, most excellently, knowing that it has failed to do so.