search

TritonDataCenter / sdc-cloudapi

Triton Data Center Public HTTP API
Mozilla Public License 2.0
10 stars 24 forks source link

This, in conjunction with https://github.com/pccowboy/node-triton/tre… #9

Closed pccowboy closed 7 years ago

pccowboy commented 8 years ago

…e/addl_params,

will allow you to pass an additional parameter to 'triton instance create'.

ex: triton instance create -w --name db percona sample-256M --addl=delegate_dataset=true

beware, this patch will probably cause a rainbow to fall down and chop off a unicorn's horn, which will then fall and stab you in the big toe. Don't try this blindly, that is my job.

Seriously, there are probably many things wrong with giving provision-capable users the ability to grab extra data. For now, though, it does what I need.

Some reading on why delegate_dataset is not currently supported by someone who knows what they are doing: https://www.mail-archive.com/smartos-discuss@lists.smartos.org/msg01751.html

pccowboy commented 8 years ago

For those that wonder why I would do something so strange, I have a zpool that I imported post-install of Triton. It is configured specifically, and I want to be able to add storage from it to some of my zones. While I know I could do this other ways, node-triton satisfies the Lazy part of me, with just a couple small tweaks.

tgross commented 7 years ago

It looks like this PR has been open a while without further discussion here (maybe on the mailing list though?), so I'm not sure if this was ever integrated. But Triton doesn't accept PRs, so I'm going to close this.

pccowboy commented 7 years ago

@tgross The discussion was back here, in https://github.com/joyent/node-triton/pull/115.

Given the less-than-encouraging reception the idea got, I didn't really see any reason to pursue getting this into master. I keep it maintained in my lab, as it is handy.