Refactor lib/utils.js - Githubissues

TrueCar / react-launch-darkly

Simple component helpers to support LaunchDarkly in your React app.

MIT License

76 stars 20 forks source link

Refactor lib/utils.js #54

Open jacobmoretti opened 7 years ago

jacobmoretti commented 7 years ago

Refactor lib/utils.js by abstracting out each of the functions into separate files and placed under lib:

getLocation, I believe this was only added to allow easier mocking. We should be able to do away with this and fix the tests that relied on it.
ldClientWrapper -> ldClientWrapper.js
ldOverrideFlag -> ldOverrideFlag.js
getAllFeatureFlags -> getAllFeatureFlags.js

GarretLefler commented 7 years ago

I can help with this.

Is there a quick way to test any changes I make before I submit a pull request?

jacobmoretti commented 7 years ago

@GarretLefler Thanks for offering to lend a hand with this issue! Unfortunately there isn't a great a way to do an end-to-end test without an account with LaunchDarkly. Its also part of the reason why https://github.com/TrueCar/react-launch-darkly/issues/16 hasn't been completed yet.

Feel free to submit your PR and use the unit-tests as the measurement for now. I'll do some testing of your changes on my end as well.