TryQuiet / quiet

A private, p2p alternative to Slack and Discord built on Tor & IPFS
https://www.tryquiet.org
GNU General Public License v3.0
1.94k stars 85 forks source link

Fix/tweak settings designs (#2537) #2561

Closed mike-kiss closed 2 months ago

mike-kiss commented 3 months ago

This PR:

Pull Request Checklist

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

mike-kiss commented 3 months ago

Light Mode: image image image

Dark mode: image image image

holmesworcester commented 3 months ago

@jgaylor do you have any feedback on these screenshots? (this is mike's adaptation of the new mobile-style settings designs for desktop.)

jgaylor commented 3 months ago

Thanks for sharing this. Here are some quick thoughts:

Dark/light mode: Overall, it looks good except for the radio buttons and the visibility icon. For icons, we should probably use grayscale. For radios in dark mode, the colors should be reversed, but that would be temporary anyway based on my comments later...

Panels: It's difficult to tell if they all have the same width since the screenshots are at various zoom levels, but they should if not.

Additionally, we're mixing existing content layout with the new drawer, so there's no clear guide for how that should look. And design should layout this view in the new system. For example, the Notifications drawer needs a design that matches our new convention (action row with a checkmark).

Holmes mentioned this will be on a branch soon, which will make it easier for me to review in more detail.

ikoenigsknecht commented 3 months ago

Code looks good but we should fix the desktop tests. That should just require updating snapshots.