search

TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
93 stars 23 forks source link

Add more tests; start testing distances #10

Closed lmcinnes closed 4 years ago

lmcinnes commented 4 years ago

Started testing most of the vectorizers at a very basic level. Began a testing module for the distances. I would welcome help writing extra tests for those.

codecov-io commented 4 years ago

Codecov Report

Merging #10 into master will increase coverage by 25.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #10       +/-   ##
===========================================
+ Coverage   48.88%   74.04%   +25.15%     
===========================================
  Files           7        8        +1     
  Lines         943     1021       +78     
===========================================
+ Hits          461      756      +295     
+ Misses        482      265      -217
Impacted Files Coverage Δ
vectorizers/_vectorizers.py 85.08% <100.00%> (+24.14%) :arrow_up:
vectorizers/tests/test_common.py 100.00% <100.00%> (+3.65%) :arrow_up:
vectorizers/tests/test_distances.py 100.00% <100.00%> (ø)
vectorizers/distances.py 36.33% <0.00%> (+23.52%) :arrow_up:
vectorizers/utils.py 88.88% <0.00%> (+42.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89eb524...8cec839. Read the comment docs.

lmcinnes commented 4 years ago

Total coverage should now be up to 87%, which is almost respectable. Most of the distances are now tested in at least some way.