TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
93 stars 23 forks source link

Fixed a memory allocation bug in MultiSetCooccurrenceVectorizer adde… #119

Closed jc-healy closed 1 year ago

jc-healy commented 1 year ago

…d a small unit test to catch the memory error.

lmcinnes commented 1 year ago

Seems i need to fix something in the list based Wasserstein vectorizer code ...

codecov-commenter commented 1 year ago

Codecov Report

Merging #119 (dff6648) into master (b0c2fed) will increase coverage by 0.07%. The diff coverage is 80.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   91.15%   91.23%   +0.07%     
==========================================
  Files          34       34              
  Lines        4849     4869      +20     
==========================================
+ Hits         4420     4442      +22     
+ Misses        429      427       -2     
Impacted Files Coverage Δ
vectorizers/multi_token_cooccurence_vectorizer.py 96.85% <73.33%> (-3.15%) :arrow_down:
vectorizers/tests/test_common.py 99.82% <100.00%> (+<0.01%) :arrow_up:
vectorizers/tests/test_signature_vectorizer.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more