search

TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
97 stars 23 forks source link

[BUG] Broken links in docs #139

Open cakiki opened 2 weeks ago

cakiki commented 2 weeks ago

Clicking on any vectorizer here in the functions column leads to a 404 page: https://vectorizers.readthedocs.io/en/latest/sequence_taxonomy.html#Vectorizer-Functions

Some of the hyperlinks also include a weird space in them (e.g., KDEV ectorizer) even though that's not in the original notebook.

I'd submit a PR but I have no idea how to fix this.

lmcinnes commented 2 weeks ago

I think it's because the API docs got broken at some point -- which in turn is due to sphinx autodoc which I don't really understand that well. I'll see if I can figure out something.

cakiki commented 1 week ago

@lmcinnes Abusing this issue for a related question so as not to open a new one: how should I go about sending PRs to a notebook? Should I re-run the whole thing locally, or rather just edit it as a JSON?

lmcinnes commented 1 week ago

Best to just rerun the whole thing logically. That way if the library has changed and something is broken it can get fixed in the notebook.

On Fri, Nov 15, 2024 at 7:50 AM Christopher Akiki @.***> wrote:

@lmcinnes https://github.com/lmcinnes Abusing this issue for a related question so as not to open a new one: how should I go about sending PRs to a notebook? Should I re-run the whole thing locally, or rather just edit it as a JSON?

— Reply to this email directly, view it on GitHub https://github.com/TutteInstitute/vectorizers/issues/139#issuecomment-2478742808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3IUBNXT2LG25J3TBROUH32AXUXZAVCNFSM6AAAAABRK6TYZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZYG42DEOBQHA . You are receiving this because you were mentioned.Message ID: @.***>