TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
93 stars 23 forks source link

Rename dictionaries to common naming scheme #20

Closed lmcinnes closed 4 years ago

lmcinnes commented 4 years ago

Rename column dictionaries to common naming schemes and rerun black on everything (it changed some string quoting).

lmcinnes commented 4 years ago

I went to change TextMAP and I see we have a different notion of column_dictionary_ there. Colin described the column dictionary as mapping column numbers to the feature, and that made sense to me; the inverse maps from features to column indices. Is that what we want, because things are currently the other way in TextMAP and we should be consistent.