Added build_tree_skip_grams()

[jc-healy]

Well, blast. I'll see if I can get that added back in.

On Tue, May 5, 2020 at 3:16 PM cjweir notifications@github.com wrote:

@cjweir commented on this pull request.

In vectorizers/tests/test_common.py https://github.com/TutteInstitute/vectorizers/pull/31#discussion_r420346524 :

@@ -391,26 +403,3 @@ def test_wass1d_transfomer(): kantorovich1d(histogram_data[i], histogram_data[j]), np.sum(np.abs(result[i] - result[j])), )

- -def test_node_removal():

• graph = scipy.sparse.random(10, 10, 0.1, format="csr")
• node_to_remove = np.argmax(np.array(graph.sum(axis=0)).T[0])
• graph_less_node = remove_node(graph, node_to_remove, inplace=False)
• assert (graph != graph_less_node).sum() > 0
• with pytest.raises(ValueError):
• graph_less_node = remove_node(graph, node_to_remove, inplace=True)
• inplace_graph = graph.tolil()

It looks like your merge in the test_common accidentally removed Lelands test_node_removal

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TutteInstitute/vectorizers/pull/31#pullrequestreview-406082112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3IUWVGTTH5PDWHEMPX5WTRQBQYXANCNFSM4MZVARLA .

[lmcinnes]

Merging seeing as Colin's issue was also dealt with.