search

TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
93 stars 23 forks source link

Removed the resizing of trees. #36

Closed cjweir closed 4 years ago

cjweir commented 4 years ago

The error is in remove_node again

lmcinnes commented 4 years ago

That's a legitimate error though. There is a corner case in remove_node it seems.

Edit: Actually this might also be due to a self-loop issue. I'm working to make sure we remove self-loops. It should be noted, however, that this is generally an issue with remove_node, and the fact that it can't handle self-loops is potentially a problem.

See PR #37 for a potential fix.