search

TutteInstitute / vectorizers

Vectorizers for a range of different data types
BSD 3-Clause "New" or "Revised" License
93 stars 23 forks source link

Ensure contiguous arrays in optimal transport vectorizers #90

Closed lmcinnes closed 2 years ago

lmcinnes commented 2 years ago

If a user passes in 'F' layout 2D arrays for vectors it can cause an error from numba that is hard for a user to decode. Remedy this by simply ensuring all the arrays being added are 'C' layout.

codecov-commenter commented 2 years ago

Codecov Report

Merging #90 (069a79a) into master (210a9ff) will not change coverage. The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          28       28           
  Lines        4487     4487           
=======================================
  Hits         4061     4061           
  Misses        426      426
Impacted Files Coverage Δ
vectorizers/linear_optimal_transport.py 93.00% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 210a9ff...069a79a. Read the comment docs.