Just identify the three browser agents

TwanoO67 / ngx-admin-lte

Admin LTE for Angular 2/4/6/8 as a NPM package

MIT License

109 stars 47 forks source link

Just identify the three browser agents #17

Closed catull closed 7 years ago

catull commented 7 years ago

What is the purpose of calculating exactly which windows browser version is used? All that matters is WHETHER the browser is a Microsoft one - MSIE, Trident or Edge. No benefit in knowing more than that.

catull commented 7 years ago

Please explain why in login.component.ts the call to

window.dispatchEvent( new Event( 'resize' ) );

is performed unconditionally ?

TwanoO67 commented 7 years ago

This one is needed because in "most" case, the first resize event is poped before the angular application is loaded. So the AdminLTE column resizing took place too early. Resulting in a page that don't take all the size available.

It's difficult to reproduce because it's related to cpu/network performance, but it's appear to be not browser-related, so it's performed unconditionnaly.

catull commented 7 years ago

So, the resolution is either

the code is not changed, but we add specific tests ?
we simplify the code, add a note that perhaps we have to revisit it.

I am biased, given I have raised this issue with one of the options.

I can live with either one of the options, the current situation is displeasing though.

TwanoO67 commented 7 years ago

I have raised this issue with one of the options

What issue ? the column sizing ? I though it was fix by the resizing event. Are you able to reproduce ? On what browser ?

I will merge your proposition for the moment (as it keep the code as a comment). But we should recreate an issue about that if the case is still happening.

catull commented 7 years ago

I agree.