search

TweeZcodeCompiler / twee_zcode_compiler

compiler project at FU Berlin
MIT License
3 stars 0 forks source link

Revert "Img to ascii" #65

Closed ottne closed 9 years ago

ottne commented 9 years ago

Reverts manuelpolzhofer/twee_zcode_compiler#60

This can't be merged, in my opinion. The approach to execute an external shell command from within the program is error prone and raises security issues. The program does not deal with the case, that the shell command is not available on the machine. It would be much better to include the source files from jp2a into the project and use them directly.

ottne commented 9 years ago

For some reason I cannot reopen #60. This is unfortunate, but in order to implement this feature in a robust manner, we would have to rewrite most of the code anyways.