search

Twinside / Rasterific

A drawing engine in Haskell
BSD 3-Clause "New" or "Revised" License
140 stars 11 forks source link

Touched up the comments a bit #31

Open SwiftsNamesake opened 7 years ago

SwiftsNamesake commented 7 years ago

Sorry about the auto-formatting stuff, I'll fix it if it's too much.

Twinside commented 7 years ago

Hi, sorry I didn't had time to reply to the clarification ticket, some remarks:

Otherwise, thanks, I see that I made a lot of typos :]

SwiftsNamesake commented 7 years ago
  1. To my mind, stroking is something you do to a cat, but if it's the accepted term, I'll undo the changes I made :P
  2. I'll have a second look at that one.
  3. Yeah, I thought as much. I should've turned off stylish-haskell straight away. I'll fix that.

You're very welcome. Is there anything else that you'd like to do with this library, that you might not have time for yourself at the moment?

2017-09-20 13:56 GMT+02:00 Vincent Berthoux notifications@github.com:

Hi, sorry I didn't had time to reply to the clarification ticket, some remarks:

  • Stroking is an accepted term in the domain, I wouldn't change it
  • Will -> Fill doesn't makes sense, maybe just removing the word would work.
  • I'm don't like the alignment of imports (a pita to maintain it) and various free indentation changes, as it breaks the history.

Otherwise, thanks, I see that I made a lot of typos :]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Twinside/Rasterific/pull/31#issuecomment-330829103, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5zBGjdKCGesQpxxUjbw1o80sIMpYczks5skP1XgaJpZM4PdbFn .

-- Hälsningar Jonatan H Sundqvist