[TT-13326] - Adds sidecars

vanny96 commented 1 month ago

Description

Adds the capability of adding sidecars to the gateway pod trough the .gateway.extraContainers field

https://tyktech.atlassian.net/browse/TT-13326

Motivation and Context

As per the issue, it allows to deploy sidecars to the pod. One good example would be GRPC plugins

Test Coverage For This Change

None

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)
[ ] Documentation updates or improvements.

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
[x] Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
[ ] My change requires a change to the documentation.
- [ ] I have manually updated the README(s)/documentation accordingly.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

vanny96 commented 1 month ago

Hey, sure thing, I'll get to it either later today or tomorrow!

buraksekili commented 1 month ago

hi @vanny96, I believe I expressed myself incorrectly. What I actually meant was that I wanted to add the newly introduced extraContainers configuration to the tyk-gateway section in the values.yaml file of each chart.

For example, at the moment, if we use tyk-stack, we can't configure extraContainers through values.yaml file explicitly unless I know the existence of such a configuration. Can you please update values.yalm file of the charts (tyk-stack, tyk-control-plane, tyk-data-plane, and tyk-oss) so that values.yalm file of these (for instance, tyk-stack's file, here) include the changes you've added? Let me know if you have any questions. The PR looks great, and i'd like to proceed with merging.

vanny96 commented 1 month ago

Huh, I just interpreted it wrong, you were super clear, I'll get to it and at this point I might add it for everything 😅

vanny96 commented 1 month ago

@buraksekili I think now it should be good! Can you double check it?

buraksekili commented 1 month ago

looks perfect! i'll hand over the PR to the team for internal testing. thank you for your collaboration!

TykTechnologies / tyk-charts