[TT-13175] add t.helper to helper functions - Githubissues

TykTechnologies / tyk

Tyk Open Source API Gateway written in Go, supporting REST, GraphQL, TCP and gRPC protocols

Other

9.75k stars 1.09k forks source link

[TT-13175] add t.helper to helper functions #6587

Closed jeffy-mathew closed 2 months ago

jeffy-mathew commented 2 months ago

User description

Description

Add t.helper to helper functions to address sonarcloud lint issuess

Related Issue

https://tyktech.atlassian.net/browse/TT-13175

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

[ ] I ensured that the documentation is up to date
[ ] I explained why this PR updates go.mod in detail with reasoning why it's required
[ ] I would like a code coverage CI quality gate exception and have explained why

PR Type

Tests

Description

Added t.Helper() to multiple test functions in internal/policy/apply_test.go to improve clarity and debugging capabilities.
This change addresses SonarCloud lint issues by marking helper functions, making it easier to identify the source of test failures.

Changes walkthrough 📝

Relevant files

Tests

apply_test.go

Add `t.Helper()` to test functions for improved clarity

internal/policy/apply_test.go

Added t.Helper() to multiple test functions to improve test clarity.

Enhanced test functions for better error reporting and debugging.

+26/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

github-actions[bot] commented 2 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No key issues to review

github-actions[bot] commented 2 months ago

PR Code Suggestions ✨

No code suggestions found for the PR.

github-actions[bot] commented 2 months ago

API Changes

no api changes detected

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud