Merging to release-5.3: [TT-12814] Make schema more flexible, don't enforce additionalProperties: false (#6640)

buger commented 1 month ago

User description

TT-12814 Make schema more flexible, don't enforce additionalProperties: false (#6640)

User description

Summary	Make OAS JSON schema more flexible (do not enforce additionalProperties)
Type	Bug
Status	In Dev
Points	N/A
Labels	-

https://tyktech.atlassian.net/browse/TT-12814

PR Type

Enhancement

Description

Removed additionalProperties: false from multiple object definitions in the JSON schema to enhance flexibility.
This change allows additional properties in the schema, making it more compatible and less strict.

Changes walkthrough 📝

Relevant files

Enhancement

x-tyk-api-gateway.json

Relax schema
strictness by removing `additionalProperties:
false`

apidef/oas/schema/x-tyk-api-gateway.json

Removed additionalProperties: false from multiple object definitions.

Enhanced flexibility of the JSON schema by allowing additional
properties.

+1/-73

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Co-authored-by: Tit Petric tit@tyk.io

PR Type

Enhancement

Description

Removed additionalProperties: false from multiple object definitions in the JSON schema to enhance flexibility.
This change allows additional properties in the schema, making it more compatible and less strict.

Changes walkthrough 📝

Relevant files

Enhancement

x-tyk-api-gateway.json

Relax schema strictness by removing `additionalProperties: false`

apidef/oas/schema/x-tyk-api-gateway.json

Removed additionalProperties: false from multiple object definitions.

Enhanced flexibility of the JSON schema by allowing additional
properties.

+1/-72

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

github-actions[bot] commented 1 month ago

API Changes

no api changes detected

github-actions[bot] commented 1 month ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis ✅** **[6640](https://github.com/TykTechnologies/tyk/issues/6640) - Fully compliant** Fully compliant requirements: - Make OAS JSON schema more flexible - Do not enforce additionalProperties: false in the schema

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Schema Validation
Ensure that the removal of 'additionalProperties: false' does not introduce unintended side effects or security issues by allowing unexpected properties.

github-actions[bot] commented 1 month ago