[TT-13508] Streams poor performance when reconnecting to a Streams API

buraksezer commented 3 weeks ago

User description

PR for https://tyktech.atlassian.net/browse/TT-13508

Changes:

Bento updated to this commit: https://github.com/warpstreamlabs/bento/commit/755c497be8a38fe4f08dd439ef7a447c5e1b84e5
removeStream uses the correct key to remove an inactive stream, not combining it with the API ID.

PR Type

Bug fix, Enhancement

Description

Fixed a bug in the removeStream function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID.
Updated the google.golang.org/grpc dependency to version v1.67.0.
Updated the github.com/warpstreamlabs/bento dependency to a specific commit for improved performance.
Updated several other dependencies to their latest versions to ensure compatibility and leverage new features.

Changes walkthrough 📝

Relevant files

Bug fix

manager.go

Correct stream removal logic in `removeStream` function

ee/middleware/streams/manager.go

Fixed the removeStream function to use the correct key for stream
removal.

Removed the combination of API ID with stream ID for stream
identification.

+2/-4

Dependencies

go.mod

Update dependencies to latest versions

go.mod

Updated google.golang.org/grpc to version v1.67.0.

Updated github.com/warpstreamlabs/bento to a specific commit.

Updated various dependencies to newer versions.

+65/-45

Additional files (token-limit)

go.sum

...

go.sum ...

+1054/-103

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

buger commented 3 weeks ago

:broken_heart: The detected issue is not in one of the allowed statuses :broken_heart:

Detected Status	Open	:x:
Allowed Statuses	In Dev,In Code Review,Ready for Testing,In Test,In Progress,In Review	:heavy_check_mark:

Please ensure your jira story is in one of the allowed statuses

github-actions[bot] commented 3 weeks ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Refactoring
The changes in the `removeStream` function simplify the stream ID handling by directly using `streamID` instead of constructing a `streamFullID`. This should be carefully tested to ensure that it does not affect the functionality where multiple APIs might share the same `streamID` but differ in `APIID`.

github-actions[bot] commented 3 weeks ago