TykTechnologies / tyk

Tyk Open Source API Gateway written in Go, supporting REST, GraphQL, TCP and gRPC protocols
Other
9.75k stars 1.09k forks source link

[TT-13607] Only import components/io and components/kafka #6720

Closed buraksezer closed 1 week ago

buraksezer commented 1 week ago

User description

Attempt to fix TT-13607

We should not need to import all components. I also ran go mod tidy to reduce the dependency graph.

Initial memory usage::

I tested the changes locally with Kafka & labs-streams sample. It works as usual.


PR Type

enhancement, dependencies


Description


Changes walkthrough 📝

Relevant files
Enhancement
stream.go
Optimize component imports to reduce memory usage               

ee/middleware/streams/stream.go
  • Removed import of all components.
  • Added specific imports for components/io and components/kafka.
  • +2/-1     
    Dependencies
    go.sum
    Clean up and update Go module dependencies                             

    go.sum
  • Removed multiple unused module dependencies.
  • Updated dependency checksums.
  • +1/-1094

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    buger commented 1 week ago

    :broken_heart: The detected issue is not in one of the allowed statuses :broken_heart:

    Detected Status Open :x:
    Allowed Statuses In Dev,In Code Review,Ready for Testing,In Test,In Progress,In Review :heavy_check_mark:

    Please ensure your jira story is in one of the allowed statuses

    github-actions[bot] commented 1 week ago

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Import Specificity
    The PR replaces a broad import with specific component imports. Ensure that no other components from the previously imported package are required elsewhere in the application to avoid runtime issues.
    github-actions[bot] commented 1 week ago

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    github-actions[bot] commented 1 week ago

    API Changes

    no api changes detected
    sonarcloud[bot] commented 1 week ago

    Quality Gate Failed Quality Gate failed

    Failed conditions
    0.0% Coverage on New Code (required ≥ 80%)

    See analysis details on SonarQube Cloud

    buraksezer commented 1 week ago

    /release to release-5.7

    tykbot[bot] commented 1 week ago

    Working on it! Note that it can take a few minutes.

    buraksezer commented 1 week ago

    /release to release-5.7.0

    tykbot[bot] commented 1 week ago

    @buraksezer Seems like there is conflict and it require manual merge.

    tykbot[bot] commented 1 week ago

    Working on it! Note that it can take a few minutes.

    tykbot[bot] commented 1 week ago

    @buraksezer Seems like there is conflict and it require manual merge.