Closed buger closed 1 week ago
API Changes
no api changes detected
Here are some key observations to aid the review process:
**๐ซ Ticket compliance analysis โ ** **[6720](https://github.com/TykTechnologies/tyk/issues/6720) - Fully compliant** Fully compliant requirements: - Optimize the import statements in `stream.go` to include only necessary components (`io` and `kafka`), reducing memory usage on cold start. - Clean up the `go.sum` file by removing unused dependencies, which helps in reducing the dependency graph. Not compliant requirements: - None |
โฑ๏ธ Estimated effort to review: 2 ๐ต๐ตโชโชโช |
๐งช No relevant tests |
๐ No security concerns identified |
โก Recommended focus areas for review Incorrect Import The import statement for `components/nats` is added, which contradicts the ticket's requirement to only include `io` and `kafka`. |
No code suggestions found for the PR.
Failed conditions
0.0% Coverage on New Code (required โฅ 80%)
User description
TT-13607 Only import components/io and components/kafka (#6720)
User description
Attempt to fix TT-13607
We should not need to import all components. I also ran
go mod tidy
to reduce the dependency graph.Initial memory usage::
I tested the changes locally with Kafka & labs-streams sample. It works as usual.
TT-13607: https://tyktech.atlassian.net/browse/TT-13607?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
PR Type
enhancement, dependencies
Description
stream.go
to include only necessary components (io
andkafka
), reducing memory usage on cold start.go.sum
file by removing unused dependencies, which helps in reducing the dependency graph.Changes walkthrough ๐
stream.go
Optimize component imports to reduce memory usage
ee/middleware/streams/stream.go
components/io
andcomponents/kafka
.go.sum
Clean up and update Go module dependencies
go.sum
PR Type
Enhancement, Dependencies
Description
stream.go
to include only necessary components (io
,kafka
, andnats
), reducing memory usage on cold start.go.mod
file by removing unused dependencies, which helps in reducing the dependency graph.Changes walkthrough ๐
stream.go
Optimize component imports to reduce memory usage
ee/middleware/streams/stream.go
components/io
,components/kafka
, andcomponents/nats
.go.mod
Clean up and update Go module dependencies
go.mod
go.sum
...
go.sum ...