fix: List item shortcuts throwing errors

TypeCellOS / BlockNote

A React Rich Text Editor that's block-based (Notion style) and extensible. Built on top of Prosemirror and Tiptap.

https://www.blocknotejs.org/

Mozilla Public License 2.0

6.79k stars 476 forks source link

Closed matthewlipski closed 2 weeks ago

matthewlipski commented 2 weeks ago

There was a regression in #1137 which broke keyboard shortcuts for bullet and check list items, which this PR addresses

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote	✅ Ready (Inspect)	Visit Preview	Nov 14, 2024 1:03pm
blocknote-website	✅ Ready (Inspect)	Visit Preview	Nov 14, 2024 1:03pm

YousefED commented 2 weeks ago

Nice. would it be easy to add tests for this?

matthewlipski commented 2 weeks ago

Nice. would it be easy to add tests for this?

Would have to be e2e tests I think, as this bug is not from incorrect logic, but passing in the wrong editor due to lack of type safety.