TypeStrong / ntypescript

Nicer TypeScript for API devs
https://www.npmjs.com/package/ntypescript
Other
116 stars 20 forks source link

typescriptServices.d.ts(5082,44): error TS1110: Type expected. #6

Closed s-panferov closed 9 years ago

s-panferov commented 9 years ago

It looks like that an error is in the file:

    function isTemplateLiteralKind(kind: SyntaxKind): boolean;
    function isBindingPattern(node: Node): ;
    function isInAmbientContext(node: Node): boolean;
nycdotnet commented 9 years ago

This is interesting because our bin/typescriptServices.d.ts file is about 5x longer than the one in TypeScript. I'm looking into it.

basarat commented 9 years ago

Because of this bug : https://github.com/Microsoft/TypeScript/issues/3761

And a fix is on the way : https://github.com/Microsoft/TypeScript/pull/3763

I've been fixing it manually (in the verification step https://github.com/TypeStrong/ntypescript/blob/master/CONTRIBUTING.md#manually). I'll do that again right now for a new publish

basarat commented 9 years ago

This is interesting because our bin/typescriptServices.d.ts file is about 5x longer than the one in TypeScript.

Because we make the internal API's public ;) I move the responsibility from the TS team to the API consumer :rose:

Code : https://github.com/TypeStrong/ntypescript/blob/master/prepare.sh#L16-L18

basarat commented 9 years ago

Published with manual fix. Leaving open till its fixed upstream

s-panferov commented 9 years ago

@basarat thanks!

nycdotnet commented 9 years ago

Thanks, Bas.

basarat commented 9 years ago

Fixed upstream 🌹