TypeTogether / Playpen-Sans

TypeTogether Playpen Sans font.
SIL Open Font License 1.1
32 stars 2 forks source link

Fail: Dotted circle needs to represent all the marks #25

Open vv-monsalve opened 6 days ago

vv-monsalve commented 6 days ago
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
> > The dotted circle character (U+25CC) is inserted by shaping engines before > mark glyphs which do not have an associated base, especially in the context > of broken syllabic clusters. > > For fonts containing combining marks, it is recommended that the dotted circle > character be included so that these isolated marks can be displayed properly; > for fonts supporting complex scripts, this should be considered mandatory. > > Additionally, when a dotted circle glyph is present, it should be able to > display all marks correctly, meaning that it should contain anchors for all > attaching marks. > > A fontmake filter can be used to automatically add a dotted_circle to a font: > > fontmake --filter 'DottedCircleFilter(pre=True)' --filter '...' > > Original proposal: https://github.com/fonttools/fontbakery/issues/3600 * 🔥 **FAIL**

The following glyphs could not be attached to the dotted circle glyph:

- dagesh-hb

- holam-hb

- holamhaser-hb

- ogonekcomb

- shindot-hb

- sindot-hb

- slashlongcomb

- slashshortcomb

- strokelongcomb

- strokeshortcomb
[code: unattached-dotted-circle-marks]
josescaglione commented 15 hours ago

This is sorted already