search

UAlbertaALTLab / morphodict

Plains Cree Intelligent Dictionary
https://itwewina.altlab.app/
Apache License 2.0
21 stars 12 forks source link

Switch unspecified actor translation from +X 'someone' to +XPl 'people' #1178

Open aarppe opened 1 week ago

aarppe commented 1 week ago

According to AEW, the more appropriate translation for the unspecified actor (+X, +XO, +PxX) is 'people' (rather than 'someone').

The English phrase FSTs already support this, using the tags (+XPl, +XPlO, +PxXPl) to recognize and generate 'people'.

This conversion to/from crk (+X, +XO, +PxX) to/from eng (+XPl, +XPlO, +PxXPl) needs to be implemented in the tag mappings, and the tests need to use people.

aarppe commented 1 week ago

@fbanados I tried to already implement this in the main and dev branches, but ran into an error I couldn't resolve.

fbanados commented 1 week ago

I think you mean that tests need to use people instead of someone

aarppe commented 1 week ago

Yes, I corrected my original note above: nîminâniwan ~ 'people dance'.

fbanados commented 1 week ago

Although all test currently pass, the robot definitions are populated at importjsondict time. I've started running the command on the itwewina.altlab.dev docker container, but it looks like it will take a while. Once that's finished, I'll change the status of this issue to review.

fbanados commented 4 days ago

This behaviour has been deployed to itwewina.altlab.dev, to be reviewed and issue closed.