search

UBC-MDS / DSCI522_group315

MIT License
0 stars 3 forks source link

Download script failure - testing #12

Closed ksedivyhaley closed 4 years ago

ksedivyhaley commented 4 years ago

Download script halts execution with message "URL doesn't exist", but works if your test using url.exists is removed. The test is a good idea but it looks like there's a possibility for false negatives on URLs.

SamEdwardes commented 4 years ago

Thank you for the catch. It looks to be an RCurl. The testing did work on our computer, so maybe a version of RCurl issue? Either way agreed this can be removed.

ksedivyhaley commented 4 years ago

Based on my quick search for similar errors it looks like it might be something to do with the internet configuration.

I'm also noting you haven't listed dependencies - what version of RCurl are you using? I'm running RCurl_1.95-4.12.

It is important to have tests, so this should either be fixed or replaced with a better test.

SamEdwardes commented 4 years ago

Thanks for the follow up. We will list dependencies in a future release. I think the best course of action on this item is to just remove the url.exists() check and just let the script fail on its own if no valid URL is give.

SamEdwardes commented 4 years ago

@scao1 and @sweber15 I have updated the download script and will include in the next PR.

SamEdwardes commented 4 years ago

Corrected in #14