UBC-MDS / f1-2021-analysis

A dashboard summarizing the Formula 1 2021 season results and highlights
https://eric1208.shinyapps.io/f1-2021-analysis/
MIT License
0 stars 4 forks source link

Milestone 1 Grading and Feedback #30

Open ogarland opened 1 year ago

ogarland commented 1 year ago

Congratulations on finishing milestone 1! We can see you put a lot of work into this project, nice work! Below we list some specific feedback you can use to improve your project.

Mechanics 4/4

Section 1: Motivation and purpose: writing: 0/2, reasoning: 8/8 proposal.md: Several grammatical or spelling errors are present (2-5/250 words). -2 writing •Review capitalization, punctuation, and spacing.

Section 2: Description of data: writing: 2/2, reasoning: 6/8 •The level of description in the dataset is very general and it is not focusing in the variables that are important for the analysis. No need to tell us what the CSV files are, just focus on the key information that you will be using, -1 reasoning •There is no evidence of data quality analysis. Are there missing values? Are these values an important percentage of the dataset? -1 reasoning

Section 3: Research questions and usage scenarios: writing: 0/2, reasoning: 12/12 •Several grammatical or spelling errors are present. Repeated sentences/messages (first 3 sentences can be reduced). (2-5/250 words). -2 writing

Section 4: Description of the app and sketch: viz: 10/10, writing: 2/2, reasoning: 3/3 •Just a note, a slider doesn’t seem like an appropriate choice to select races.

Section 5: Teamwork contract and collaborative documentation: reasoning: 4/4

Section 6: Code of conduct: 1/1

Section 7: Contribution guidelines: 1/1

Grade: 53/59 If anything is unclear, please feel free to ask questions in this issue thread.

erictsai1208 commented 1 year ago

@ogarland I am wondering where exactly are you finding several grammar and spelling mistakes in Section 1 and 3. I have reread the paragraphs for both and could not identify significant errors. I believe the first three sentences in Section 3 are necessary in highlighting the research questions and usages that our app can address. Thanks!

ogarland commented 1 year ago

Just some quick fixes! For example, at the very beginning of section 1, this is all one sentence "Our role: Data scientists in the sports industry Target audience: Formula 1 Fans interested in analyzing the 2021 Season The 2021 Season for Formula 1 World Championship was an intense season filled with suspense and plot twists. ", there either needs to be spacing or punctuation added. Also in section 1, this is a run-on sentence "As data scientists in the industry who seek to present this data in a more informative and interesting way, we propose building a data visualization app that allows users to easily find overall information for the season, filter for specific teams, drivers, or tracks while being to see how they compare with each other, and clearly and concisely present key summary statistics and information for each race/team/driver. "

In section 3, you can write it to be more impactful. I had to read the paragraph several times to understand the message in each sentence because they are written so similarly. You could even consider writing them as research questions in bullet point form to really drive home what the user will be able to do in your app. I really like this part, "With this information, Tom can identify the turning points in the season in which his favorite driver surpassed his rivals." because it means he is making some key takeaways from your app, but it's being lost in the wordiness of the paragraph.

Hope that helps!