Typed vizier output - Githubissues

UBOdin / mimir

Data-ish exploration through SQL+Uncertainty

http://mimirdb.info

Apache License 2.0

26 stars 13 forks source link

Typed vizier output #324

Closed okennedy closed 5 years ago

okennedy commented 5 years ago

Queries sent to MimirVizier now return results with the right JSON types (JsNumber, JsBoolean, etc...) instead of just JsString.

Translations are as follows:

IntPrimitive, FloatPrimitive -> JsNumber
StringPrimitive, TypePrimitive, RowIdPrimitive -> JsString
BoolPrimitive -> JsBoolean
DatePrimitive -> JsObject( "year", "month", "date" )
TimestampPrimitive -> JsObject( "year", "month", "date", "hour", "min", "sec", "msec" )
IntervalPrimitive -> JsString (admittedly a bit hacky)

okennedy commented 5 years ago

Tested on my private instance. Apart from bugs resulting from python code now seeing proper types rather than strings, everything seems to be in order.