UCL / frrant

2 stars 0 forks source link

Switch to CKEditor #453

Closed tcouch closed 1 month ago

tcouch commented 2 months ago

closes #423 and #452 related to #433 , may have resolved it since it caches now

Trying CKEditor as a fix for Quill's broken mention plugin (plus the weird pasting behaviour too hopefully)

tcouch commented 1 month ago

It just occurred to me that the html for existing footnotes won't be compatible with the new footnotes style. We'll need to write a migration to convert them.

tcouch commented 1 month ago

The introduction on WorkForm and BookForm needs to have the editor enabled.

tcouch commented 1 month ago

Public commentary inline edit form needs to have its editor enabled

tcouch commented 1 month ago

Commentary apparatus criticus mentions aren't working ~if there are two original texts~

acholyn commented 1 month ago

The introduction on WorkForm and BookForm needs to have the editor enabled.

do they not use the IntroductionFormBase? Do I also need to enable it on the AntiquarianCreateForm as well?

acholyn commented 1 month ago

Public commentary inline edit form needs to have its editor enabled

https://github.com/UCL/frrant/blob/7c753c73f94358610d963b424ca50ed7368b2b4e/src/rard/research/forms.py#L702 is this in the wrong place?

tcouch commented 1 month ago

The introduction on WorkForm and BookForm needs to have the editor enabled.

do they not use the IntroductionFormBase? Do I also need to enable it on the AntiquarianCreateForm as well?

Apparently not - it's the form you get when you create a new work or book as opposed to editing them once they're created. And yes looks like AntiquarianCreateForm also needs it.

tcouch commented 1 month ago

Public commentary inline edit form needs to have its editor enabled

https://github.com/UCL/frrant/blob/7c753c73f94358610d963b424ca50ed7368b2b4e/src/rard/research/forms.py#L702

is this in the wrong place?

Pushed a fix: I think the problem was it was inside an if block that didn't always get executed. Copied the approach used for CommentaryFormBase instead.

tcouch commented 1 month ago

The create forms for Works and Antiquarians (/work/create/ and antiquarian/create/) need to have their editors enabled.