search

UCL / rsd-engineeringcourse

Course materials for Research Software Engineering course.
http://github-pages.ucl.ac.uk/rsd-engineeringcourse/
Other
120 stars 107 forks source link

"Publishing" page #73

Open mattagape opened 6 years ago

mattagape commented 6 years ago

  1. The text refers to the course as a software carpentry course, but it isn't.

  2. In the text "UCL pays for private GitHub repositories for UCL research groups: you can find the service details on our web page." the link to the web page is broken.

  3. On this page (and on others) the sequence diagrams show a git add, followed by a git commit, and then a git commit -a. Surely this third step isn't required if the first two are executed?

  4. We have these commands (in "Tell git about the new file"): git add lakeland.md git commit -am "Add lakeland" Do we need the -a switch here?

ageorgou commented 6 years ago
ageorgou commented 6 years ago

On this page (and on others) the sequence diagrams show a git add, followed by a git commit, and then a git commit -a. Surely this third step isn't required if the first two are executed?

I think these diagrams just show what various commands do, they are not necessarily a workflow to be followed in sequence

Do we need the -a switch here?

No, we don't... I have left it in for consistency with the commands before and after, but am not particularly committed to it!