farosFreed commented 3 months ago

Notes: Refactored BlockHours to use a ref instead of JS to perform dom manipulationon the iframe height.

The previous implementation can lead to a race condition where the height does not get set correctly if the iframe has not loaded in the dom.

Checklist:

[X] I checked that it is working locally in the dev server
[X] I checked that it is working locally in the storybook
[ ] I checked that it is working locally in the library-website-nuxt dev server <--- not done yet
[ ] I added a screenshot of it working
[ ] UX has reviewed and approved this
[ ] I assigned this PR to someone on the dev team to review
[X] I used a conventional commit message
[X] I assigned myself to this PR

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-585--ucla-library-storybook.netlify.app

pghorpade commented 3 months ago

:tada: This issue has been resolved in version 3.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

UCLALibrary / ucla-library-website-components

fix: Apps-2852 fix blockhours height #585

Percy Screenshots