UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

chore: APPS-2962 move styles from page to story #619

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-2962

Notes:

When section teaser card has 3 cards we'd like the third card to align with the edge of the link. When section teaser card has fewer cards, we'd like the cards to align one after another without big gaps in between.

This PR adds styles for 3 cards to justify content to the edges, but will not change the styles for 2 cards. We do bump the gap for 2 cards to 20px minimum so that it will not ever look too different than the responsive gap between the 3 card layouts, regardless of screen size

Screenshot 2024-09-25 at 2 01 58 PM Screenshot 2024-09-25 at 2 02 08 PM

Checklist:

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-619--ucla-library-storybook.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 3.23.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: