search

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: move watchers to onmounted and remove immediate:true for some watchers we don't need to run it immediately #624

Closed pghorpade closed 1 month ago

pghorpade commented 1 month ago

Connected to APPS-2987

This PR fixes the missing header layout data after it is refreshed on client side in unmounted in Nuxt APP.VUE

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-624--ucla-library-storybook.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 3.24.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: