UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: add relative position to anchor link on card #632

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-3001

Notes:

We add position:relative to force the link element onto the card it belongs to, instead of it floating on top of the top card in the list!

Also removed some extra li styles as directed in the ticket

Checklist:

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-632--ucla-library-storybook.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 3.28.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: