UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: Apps-2922 remove time stamp on homepage #637

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-2922

Component Updated: CardMeta.vue

Stories: ~/stories/SectionWrapper.stories.js

Notes:

The main issue was the theme !== undefined check, which was meant to return false on the library-website-nuxt site. However, during testing I realized the site has a theme now, set to ''. So the undefined check was being passed and the time was rendering when it wasn't meant to. To fix this I made cardmeta explicitly check for ftva theme to show the time.

While testing this locally in library-website-nuxt, I noticed that we now had 2 dates showing (screenshot below). This is because of the postDate changes we made 15ish days ago that had not yet been updated on the library-website-nuxt site. To prevent this, I added a check to BlockCardWithImage to only pass the postDate when we are using the ftva theme.

Screenshot 2024-10-18 at 9 37 37 AM

Finally I added a story to SectionWrapper with the same data and theme setup as the library site homepage so this bug can be checked for.

Lastly, Our previous default stories without theme injections should maybe be updated everywhere - as they are no longer accurate. Should I do that as part of this ticket (add 'theme = '' to all default stories)?

Checklist:

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-637--ucla-library-storybook.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 3.29.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: